Skip to content

Remove prop rejection events, keep them inline with update results - #228

Merged
tudddorrr merged 1 commit into
developfrom
remove-prop-rejection-events
Aug 4, 2026
Merged

Remove prop rejection events, keep them inline with update results#228
tudddorrr merged 1 commit into
developfrom
remove-prop-rejection-events

Conversation

@tudddorrr

@tudddorrr tudddorrr commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Result types replacing event-based error handling

  • ChannelsAPI.Create and Update now return ChannelUpsertResult instead of Channel directly, wrapping success/failure status, the channel, and any rejected props.
  • FeedbackAPI.Send now returns FeedbackSendResult instead of void, including success status and rejected props.
  • LeaderboardsAPI.AddEntry now returns AddEntryResult instead of a tuple (LeaderboardEntry, bool), adding success status and rejected props.
  • PlayersAPI no longer fires OnPropsRejected separately; rejected props are returned directly via SetProp and the existing OnPlayerUpdated event.

Removal of RejectedProp event emissions

  • RejectedProp.TryEmit was removed entirely, as the pattern of emitting rejected props via events is no longer used.
  • OnChannelPropsRejected and OnPropsRejected events were removed from ChannelsAPI, FeedbackAPI, LeaderboardsAPI, and PlayersAPI.

Sample updates for new API shapes

  • All sample/demo scripts were updated to work with the new result types, checking Success/Entry properties instead of relying on events or tuples.

@tudddorrr tudddorrr added the breaking This pull request contains a breaking change label Aug 4, 2026
@tudddorrr
tudddorrr force-pushed the remove-prop-rejection-events branch 3 times, most recently from f22a92b to d747e70 Compare August 4, 2026 20:42
@tudddorrr
tudddorrr force-pushed the remove-prop-rejection-events branch from d747e70 to f3640b1 Compare August 4, 2026 21:01
@tudddorrr
tudddorrr merged commit 861db3c into develop Aug 4, 2026
3 checks passed
@tudddorrr
tudddorrr deleted the remove-prop-rejection-events branch August 4, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This pull request contains a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant