Remove leading debounces - #229
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trailing-only debounce
Shared task result
Taskresult instead of each receiving an independentTaskCompletionSource.Simplified debounce internals
SettleLeadingmethod and the leading-call branch fromDebounce(), leaving a single code path that always queues a trailing call.ProcessPendingUpdatesno longer distinguishes between leading-in-flight and trailing-queued states; it simply re-opens the window if an execution is still running.Test alignment
LeadingCall_*→TrailingCall_*).yield return nullprecedes assertions, giving the trailing call a frame to execute.debounceTimerSecondsset to0fin test setup to make trailing calls fire immediately in the next frame.