Skip to content

Moves node actions to menu bar Node menu#2149

Open
Mbeaulne wants to merge 1 commit intomasterfrom
04-23-move_actions_to_menu
Open

Moves node actions to menu bar Node menu#2149
Mbeaulne wants to merge 1 commit intomasterfrom
04-23-move_actions_to_menu

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Apr 23, 2026

Description

Adds a Node menu to the editor menu bar that consolidates node-level actions (duplicate, delete, arrange/z-index, and unpack subgraph) into a single dropdown. This menu is context-sensitive and only appears when a node is selected.

As part of this change, the inline TaskActionsBar (with its individual DeleteTaskButton, DuplicateTaskButton, and UnpackSubgraphButton components) and the StackingControls/ZIndexEditor controls from the task and IO node detail panels have been removed. Their functionality is now accessible exclusively through the new NodeMenu in the menu bar.

The EditorMenuBar has also been moved inside the ReactFlowProvider so the NodeMenu can access the React Flow instance (e.g., getNodes) needed to compute z-index ordering.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

image.png

Test Instructions

  1. Open the editor and select a task node.
  2. Confirm the Node menu appears in the menu bar.
  3. Verify Duplicate Task, Delete Task, and Arrange (Move Forward, Move Backward, Bring to Front, Send to Back) all work correctly.
  4. For a subgraph task, confirm the Unpack Subgraph option appears and functions correctly.
  5. Select an input or output node and confirm the Node menu appears with only the Arrange submenu (no duplicate/delete options).
  6. Deselect all nodes and confirm the Node menu is no longer visible.

Additional Comments

The ZIndexEditor and StackingControls components may now be unused elsewhere and can be considered for removal in a follow-up cleanup.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

🎩 Preview

A preview build has been created at: 04-23-move_actions_to_menu/b8d8d70

Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 23, 2026

@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from 050e27a to cc744af Compare April 23, 2026 15:48
@Mbeaulne Mbeaulne force-pushed the 04-23-move_colour_selector branch from 333e5e5 to 45fd6a2 Compare April 23, 2026 15:48
@Mbeaulne Mbeaulne changed the title Move actions to menu Moves node actions to menu bar Node menu Apr 23, 2026
@Mbeaulne Mbeaulne marked this pull request as ready for review April 23, 2026 15:55
@Mbeaulne Mbeaulne requested a review from a team as a code owner April 23, 2026 15:55
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from cc744af to 974a715 Compare April 23, 2026 16:39
@Mbeaulne Mbeaulne force-pushed the 04-23-move_colour_selector branch from 45fd6a2 to bff8d22 Compare April 23, 2026 16:39
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like this change. I can see merit for moving the arrange/Z-Index tools but not sure about the rest.
Maybe it would be better to always have the "Nodes" menu available, but disabled if a node isn't selected? Then we can contextualize it to other nodes as well (input, output, flex) and users at least know the menu exists before clicking a node and trying to find it.

Interested in @maxy-shpfy's thoughts

@camielvs camielvs requested a review from maxy-shpfy April 27, 2026 18:29
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch 2 times, most recently from 2e7e47b to c6cf5b0 Compare April 28, 2026 16:15
@Mbeaulne Mbeaulne force-pushed the 04-23-move_colour_selector branch 2 times, most recently from 267d2e8 to cb3919d Compare April 28, 2026 16:53
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from c6cf5b0 to 7b069e8 Compare April 28, 2026 16:53
@Mbeaulne Mbeaulne force-pushed the 04-23-move_colour_selector branch from cb3919d to 17127e6 Compare April 28, 2026 20:15
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from 7b069e8 to cb453a4 Compare April 28, 2026 20:15
@Mbeaulne Mbeaulne force-pushed the 04-23-move_colour_selector branch 2 times, most recently from bb3b4a1 to 551e84c Compare April 28, 2026 20:23
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from cb453a4 to 6a6f4c7 Compare April 28, 2026 20:23
@Mbeaulne Mbeaulne force-pushed the 04-23-move_colour_selector branch from 551e84c to 72635d4 Compare April 30, 2026 15:54
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from 6a6f4c7 to f278ba1 Compare April 30, 2026 15:54
@Mbeaulne Mbeaulne changed the base branch from 04-23-move_colour_selector to graphite-base/2149 April 30, 2026 19:56
@Mbeaulne Mbeaulne force-pushed the graphite-base/2149 branch from 72635d4 to 5a0a7d7 Compare April 30, 2026 19:59
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from f278ba1 to 8dc0276 Compare April 30, 2026 19:59
@graphite-app graphite-app Bot changed the base branch from graphite-base/2149 to master April 30, 2026 20:00
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from 8dc0276 to 9dc13a7 Compare April 30, 2026 20:00
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block - we can iterate.

Though I will make one suggestion: add "rename task" to the menu as well?

image.png

Also IO nodes don't have a delete option
image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants