馃帹 Palette: Enhanced flight card interactions and accessibility - #172
馃帹 Palette: Enhanced flight card interactions and accessibility#172TargetMisser wants to merge 1 commit into
Conversation
- Added haptic feedback (ImpactFeedbackStyle.Medium) when crossing swipe threshold on flight cards. - Added success haptic feedback (NotificationFeedbackType.Success) when a flight is successfully pinned/unpinned via swipe. - Implemented comprehensive accessibilityLabel for flight cards including status, time, and direction. - Added accessibilityActions (pin/unpin) for screen reader users. - Added accessibilityHint for opening external flight details. - Added necessary localized strings for accessibility features in IT and EN. Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fbfe47d86
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onPress={() => { openFlightradar24Flight(flightNumber).catch(() => {}); }} | ||
| accessibilityRole="link" | ||
| accessibilityLabel={`Apri ${flightNumber} su Flightradar24`} | ||
| accessibilityRole="button" |
There was a problem hiding this comment.
For screen-reader users, these cards still activate by opening the external Flightradar24 URL via onPress, but the role now announces them as buttons rather than links. In the flight list, this makes the primary action sound like an in-app button even though it navigates out to a web page; keeping accessibilityRole="link" while adding the custom pin/unpin actions would preserve the expected semantics.
Useful? React with 馃憤聽/ 馃憥.
1 participant
Enhanced the flight card component with tactile feedback and improved accessibility.
Micro-UX Improvements:
Changes:
src/i18n/translations.ts: Added strings for flight directions and accessibility hints.src/screens/FlightScreen.tsx: Integratedexpo-hapticsand expandedTouchableOpacityproperties with ARIA-equivalent attributes.PR created automatically by Jules for task 7624835847475281213 started by @TargetMisser