🎨 Palette: Flight Card Haptics & Accessibility - #179
Conversation
- Added ImpactFeedback (Medium) when swipe threshold is crossed. - Added NotificationFeedback (Success) on pin/unpin completion. - Implemented accessibilityActions for SwipeableFlightCard to support screen readers. - Added Light ImpactFeedback to header buttons and segment tabs. - Added semantic accessibilityRole="tab" and selection states. Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af2ca6d02b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| accessibilityActions={accessibilityActions} | ||
| onAccessibilityAction={onAccessibilityAction} |
There was a problem hiding this comment.
In the current card tree, the new pin/unpin action is registered on an Animated.View that is not marked accessible, while the screen-reader focus target is still the child TouchableOpacity link. In VoiceOver/TalkBack contexts this means the focused flight card will not expose the toggle_pin action, so the accessibility path added here cannot actually pin or unpin a flight; move the action/hint to the focusable touchable or make the wrapper the accessible element without losing the link behavior.
Useful? React with 👍 / 👎.
1 participant
💡 What: Enhanced the Flight screen with tactile haptic feedback and improved accessibility for screen reader users.
🎯 Why:
♿ Accessibility:
accessibilityActions("Pin flight" / "Unpin flight") to flight cards, allowing VoiceOver/TalkBack users to toggle the state via the actions menu.accessibilityHintto describe the effect of pinning.accessibilityRole="tab"andaccessibilityState={{ selected: ... }}to segment controls for standard-compliant navigation.✨ UX Polish:
expo-hapticsto provide a "tactile snap" when swiping past the threshold.PR created automatically by Jules for task 10110505373701961895 started by @TargetMisser