🎨 Palette: Flight card haptics and accessibility improvements - #182
🎨 Palette: Flight card haptics and accessibility improvements#182TargetMisser wants to merge 1 commit into
Conversation
- Added haptic feedback to swipe-to-pin interaction on flight cards - Implemented comprehensive accessibility labels for flight rows - Added accessibility actions for pinning and external links - Localized all new accessibility strings in IT and EN - Cleaned up redundant accessibility announcements in the flight list Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13ef8153eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onPress={() => { openFlightradar24Flight(flightNumber).catch(() => {}); }} | ||
| accessibilityRole="link" | ||
| accessibilityLabel={`Apri ${flightNumber} su Flightradar24`} | ||
| importantForAccessibility="no-hide-descendants" |
There was a problem hiding this comment.
When TalkBack is enabled, this hides the TouchableOpacity descendants, including the only element that has onPress and accessibilityRole="link". The wrapper is focusable but only exposes custom actions, so a normal double-tap on a flight card no longer opens Flightradar24 and the card is no longer announced as a link; users must discover the secondary action menu instead. Move the link role and a default activate handler to the accessible wrapper, or leave the touchable accessible before hiding descendants.
Useful? React with 👍 / 👎.
1 participant
💡 What: The UX enhancement added
🎯 Why: The user problem it solves
♿ Accessibility: Any a11y improvements made
accessibilityLabel.accessibilityActionsfor custom interactions.importantForAccessibility="no-hide-descendants"to prevent redundant screen reader focus.accessibilityHintfor the swipe gesture.PR created automatically by Jules for task 1866671172575269489 started by @TargetMisser