fix(a11y): label icon-only close buttons (drawer, profile switcher, shift timeline) - #189
Open
TargetMisser wants to merge 1 commit into
Open
fix(a11y): label icon-only close buttons (drawer, profile switcher, shift timeline)#189TargetMisser wants to merge 1 commit into
TargetMisser wants to merge 1 commit into
Conversation
…and shift timeline Screen readers announced nothing for these icon-only close buttons. Add accessible/accessibilityRole/accessibilityLabel and a comfortable hitSlop (re-implements stale #184 on the current components - DrawerMenu's close now lives in DrawerMenuPanel). Closes #184. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implements stale #184 on the current component tree (DrawerMenu's close button now lives in
DrawerMenuPanel, driven byTactilePressable, which forwards Pressable props).accessible+accessibilityRole="button"+accessibilityLabelon the three icon-only close buttonshitSlopfor comfortable touch targetsVerification:
npm run typecheck✓Closes #184.
🤖 Generated with Claude Code