Feat: Project - add isBillable field#93
Merged
Merged
Conversation
rafaeljusto
reviewed
Jun 11, 2026
|
|
||
| // Only one blocked time calendar is allowed per user, so a leftover from an | ||
| // interrupted run makes the "all fields" case fail until it is removed. | ||
| deleteBlockedTimeCalendar(t) |
Contributor
There was a problem hiding this comment.
Thanks! I was frequently manually deleting the blocked calendar instance in my test installation when tests failed to do so 😂
Contributor
Author
There was a problem hiding this comment.
Ah so it wasn't me!!
rafaeljusto
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
IsBillableto theprojects.Projectstruct. The v3 API returnsisBillable(the project's billable-by-default setting for time logs) on both the project list and single project endpoints, but the struct didn't model it, so anything decoding intoprojects.Projectsilently drops the field.We hit this on the Teamwork MCP server: the
twprojects-get_projecttool re-marshals this struct, so the billable setting never made it back to the model.twprojects-list_projectspasses the raw API response through and already includes it, which made the gap easy to miss.Pointer field and additive, so no breaking change.
Type of Change
Testing
go test -v ./...)The projects package tests are integration-only (skipped without a live engine) with no fixture decode tests to extend. I verified a decode/re-marshal round trip keeps the field, since that's the path that was dropping it.
Checklist