Skip to content

Solves #22#27

Open
spacemonkey1101 wants to merge 7 commits into
Technical-Hackers:masterfrom
spacemonkey1101:master
Open

Solves #22#27
spacemonkey1101 wants to merge 7 commits into
Technical-Hackers:masterfrom
spacemonkey1101:master

Conversation

@spacemonkey1101

Copy link
Copy Markdown

Solves #22

Sorry for making 2 commits. I actually forgot to fetch upstream.
Please tell me if the changes are ok

@iamsh4shank iamsh4shank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @spacemonkey1101 nice work, check my comments also please squash the commits

Comment thread app/src/main/res/values-night/strings.xml Outdated
@iamsh4shank

Copy link
Copy Markdown
Contributor

squash the commits

@iamsh4shank

Copy link
Copy Markdown
Contributor

Hey @spacemonkey1101 please add a screen shot and also squash your commits :)

@spacemonkey1101

spacemonkey1101 commented Dec 19, 2020

Copy link
Copy Markdown
Author

@robustTechie

I have to implement a lot of changes i guess

the icons and the cardview layout also needs to be changed

Screenshot_20201219-134350_Health Log.jpg

Screenshot_20201219-134343_Health Log.jpg

@iamsh4shank

Copy link
Copy Markdown
Contributor

Yeah, you need to manage each color for dark mode and light mode, for now, you can just add a basic color and then send a PR and then, later on, send another PR for adding the new colors for dark and light mode. Also, I would suggest you add this switch thing or maybe a theme button on the top overflow menu(inside three dots). After a few days, we are going to add a Setting page then we will shift all these things there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants