chore: sync README test counts from passing vitest results

[telivity-otaip]

Summary

Keeps README test badges and documentation in sync with actual passing vitest results across all workspace packages (skipped tests and skipped-only files excluded).

Changes

• scripts/sync-test-count.mjs — discovers test workspaces via pnpm, writes docs/test-stats.json, CI --check mode
• --check validates the full README via applyCounts(current, counts) === current (badge, Testing row, heading, pnpm test command, and malformed-row normalization) — not just the Testing table row
• Regression tests stale each non-table managed occurrence and assert --check would fail
• Normalizes legacy README rows where Testing and Build were concatenated on one line
• CI test job runs pnpm db:migrate before the sync check so counts match a fully migrated schema
• README badge and table rows updated (1630 passing tests / 228 files on current main)

How to test

pnpm --filter @telivityhaip/shared test -- src/sync-test-count-script.spec.js
pnpm readme:sync-tests --check

Contributor credit

@agustinjch

[agustinjch]

The synchronization mechanism itself looks sound: workspace discovery, skipped-test semantics, stats JSON, and the migration-before-test CI ordering are all reasonable, and the current isolated CI is green.

There is one merge-order blocker: the committed 1585 / 222 totals were generated against the old main. Since #349–#351 are intended to merge first and add tests/files, these values will be stale and the new --check should reject them. Please rebase #352 after #351 and run pnpm readme:sync-tests before I confirm it.

Also, the README Testing row that this script rewrites still contains two concatenated table rows:

... Unit and integration tests || Build | ...

Please split Build onto its own Markdown row and make the synchronization logic preserve the corrected structure.

After #352 lands, later PRs that add tests — especially #353 and #348 — will also need to rebase and regenerate the published counts.

[telivity-otaip]

Thanks for the review — addressed on d09ae7c (current head). Branch is rebased cleanly on main (readme/sync files only — no sibling PR code mixed in).

Merge-order / counts
Regenerated with pnpm readme:sync-tests against current main: 1585 passing / 222 files. As you noted, this will move once #349 and #351 land; we'll rebase and regen before final merge.

README table
Split Testing and Build onto separate rows. sync-test-count.mjs now normalizes legacy concatenated rows when rewriting counts.

CI
pnpm db:migrate before sync check (from earlier commit on this branch).

PR description updated with merge-order note. Ready for your re-review.

[agustinjch]

@telivity-otaip This is close. The remaining code issue is that --check validates only the Testing table row, while the synchronizer also owns the badge, heading, command count, and malformed-row normalization. One of those other locations can become stale while CI still passes.

I suggest generating the complete expected README with the same function used by sync mode and comparing it to the current content:

const expectedReadme = applyCounts(currentReadme, counts);

if (expectedReadme !== currentReadme) {
  throw new Error('README test statistics are out of date');
}

Please add regression cases that make each non-table managed occurrence stale and verify that --check fails.

After #349 and #351 land, this PR will also need a rebase, pnpm readme:sync-tests, updated totals in the PR description, and green CI. The current description still says 1585/222 while the current head contains 1595/223.

[telivity-otaip]

Addressed on 9c7ce6d:

• --check now uses applyCounts(readme, counts) !== readme (full README, not just the Testing table row)
• Regression cases cover stale badge, heading, pnpm test command, malformed Testing||Build row, and Testing table row
• Rebuilt on current main (feat(email): add bounded timeouts for outbound email providers #349/feat(webhook): dedupe deliveries with logicalEventId #350/feat(api): add shared confirmation number and property date helpers #351 landed); regenerated 1630 / 228
• PR description totals updated

[telivity-otaip]

Thanks @agustinjch — really helpful catch on the incomplete --check surface.

Addressed on 9c7ce6d:

• --check now compares the full README via applyCounts(current, counts) (badge, Testing row, heading, pnpm test command, and malformed-row normalization)
• Regression coverage for each of those non-table sites going stale
• Rebuilt on current main after feat(email): add bounded timeouts for outbound email providers #349/feat(webhook): dedupe deliveries with logicalEventId #350/feat(api): add shared confirmation number and property date helpers #351; counts regenerated to 1630 / 228

Appreciate the review — ready to merge when CI is green.