Skip to content

ci: assert the Developer ID identity imported #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TerrifiedBug merged 1 commit into from
Aug 27, 2026
Merged

ci: assert the Developer ID identity imported #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ jobs:
env:
APP_P12: ${{ secrets.DEVELOPER_ID_APP_P12_BASE64 }}
P12_PASSWORD: ${{ secrets.DEV_ID_P12_PASSWORD }}
APP_IDENTITY: ${{ secrets.APP_IDENTITY }}
run: |
if [ -z "$APP_P12" ]; then
echo "::error::DEVELOPER_ID_APP_P12_BASE64 is not set. Releases must be signed and notarized."
Expand All @@ -98,7 +99,15 @@ jobs:
security set-key-partition-list -S apple-tool:,apple:,codesign: \
-s -k "$KEYCHAIN_PW" "$KEYCHAIN" >/dev/null
security list-keychains -d user -s "$KEYCHAIN" login.keychain
security find-identity -v -p codesigning "$KEYCHAIN"
# find-identity exits 0 even when it finds "0 valid identities", so a
# p12 that imports but whose chain does not validate here would sail
# past this step and fail confusingly inside build-release.sh.
IDENTITIES="$(security find-identity -v -p codesigning "$KEYCHAIN")"
echo "$IDENTITIES"
if ! grep -qF "$APP_IDENTITY" <<<"$IDENTITIES"; then
echo "::error::$APP_IDENTITY is not a valid codesigning identity in the build keychain."
exit 1
fi

- name: Store notary credentials
env:
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ All notable changes to Browseroute are documented here (Keep a Changelog style).

- Developer ID-signed, notarized GitHub releases (same methodology as yap and TickerBar) and a Homebrew cask.
- Sparkle EdDSA key baked in; Check for Updates is live on Developer ID-signed GitHub builds (ad-hoc and Homebrew stay off). The cert check runs after launch and does not hash sealed resources.
- Release CI fails before notarize if `HOMEBREW_TAP_TOKEN` is missing, expired, or cannot push to the tap.
- Release CI fails before notarize if `HOMEBREW_TAP_TOKEN` is missing, expired, or cannot push to the tap, or if the Developer ID identity does not validate in the build keychain.
Loading