fix: configure npm provenance for 0.2.2 - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The v0.2.1 npm publish workflow now clears auth (npm trusted publishing/OIDC is configured) but fails during provenance verification with E422: package.json's repository.url is empty, but sigstore provenance requires it to match https://github.com/Teslemetry/node-tesla-fleet-api. Fix: add a repository field to package.json pointing at this exact repo (matching the shape used by other Teslemetry npm packages, e.g. projects/typescript-teslemetry/packages/api/package.json). Also bump the version to 0.2.2 rather than reusing 0.2.1, since neither prior publish attempt for 0.2.1 actually succeeded (both failed before the registry accepted anything) - 0.2.2 satisfies existing ^0.2.1 consumers. Do not touch the publish workflow itself or any other files; this is intentionally a minimal 2-line package.json change. A brief AGENTS.md/CLAUDE.md note was also added documenting the provenance repository.url requirement for future publish troubleshooting.
What Changed
Risk Assessment
✅ Low: The change is narrowly scoped and correctly adds the exact repository URL required for provenance, bumps the package to 0.2.2, leaves the publish workflow untouched, and documents the release constraint.
Testing
Inspected the complete commit scope, confirmed the publish workflow was untouched, then produced and inspected the consumer npm tarball; it exposes version 0.2.2 and the exact provenance-required repository URL, with no test artifacts left in the worktree.
Evidence: Packed npm metadata
{ "name": "tesla-fleet-api", "version": "0.2.2", "repository": { "type": "git", "url": "https://github.com/Teslemetry/node-tesla-fleet-api" } }Evidence: npm pack manifest
/tmp/no-mistakes-evidence/01KYY4X9Q6RGYHHT8GMP6C89MN/tesla-fleet-api-0.2.2.tgz)Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
git diff --name-status 026df711f0c86cf3ab040b5f69ce9b58802d3142..41c179ea42fdd914a4fb7445301aac974dde8caegit diff --unified=80 026df711f0c86cf3ab040b5f69ce9b58802d3142..41c179ea42fdd914a4fb7445301aac974dde8cae -- package.json AGENTS.md CLAUDE.mdnpm pack --ignore-scripts --pack-destination /tmp/no-mistakes-evidence/01KYY4X9Q6RGYHHT8GMP6C89MN --jsonExtractedpackage/package.jsonfrom the generated tarball and asserted package nametesla-fleet-api, version0.2.2, repository typegit, and exact URLhttps://github.com/Teslemetry/node-tesla-fleet-apigit status --shortafter packaging to verify no working-tree artifacts were created✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.