chore: remove vendored protobuf sources - #12
Merged
Conversation
…source The library already imported all protobuf types from @teslemetry/tesla-protocol; protobuf/*.proto and createPb2.sh were leftover, unreferenced vendored copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
@teslemetry/tesla-protocolpackage.src/testto@teslemetry/tesla-protocol; no file still imported from the localprotobuf/sources or a bundledsrc/pb2.protobuf/*.protoandcreatePb2.sh(theprotoc/protoc-gen-tsgenerator script) were unreferenced by any code path or build step. This PR deletes them.@teslemetry/tesla-protocolis now the sole source of Tesla protobuf types in this repo.npx tsc --noEmitand the full vitest suite (90 tests, including the crypto-sensitive signed-command tests) pass unchanged.Pipeline note: this went through the direct/no-mistakes-skip path as a trivial, unreferenced-file deletion with zero behavior change and green tests, rather than the full
/no-mistakesgate.