ci: harden the production environment and document publish recovery - #24
Merged
Conversation
Configure a required reviewer and a main-only branch policy directly on the production GitHub environment, and document that both publish jobs and their npm/PyPI legs are safe to re-run after an interruption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
productionenvironment thatpublish.yml'sreleaseandpublish-pypijobs already gate on, per the CI/release hardening follow-up to ci: gate publish on the full CI suite for the exact publish SHA #23.main-only deployment branch policy directly on theproductionGitHub environment via the API (gh api repos/Teslemetry/tesla-protocol/environments/production) - this is GitHub-side config, not somethingpublish.ymlitself controls, so there's no workflow diff for it.needs: ci/needs: [ci, release], so the environment's reviewer prompt can only fire after the reusableci.ymlgate from ci: gate publish on the full CI suite for the exact publish SHA #23 has passed for that exact SHA. GitHub also only prompts once per workflow run even though two jobs referenceproduction, so approvingreleasecoverspublish-pypitoo.changeset publishchecks the npm registry before publishing, so re-runningreleaseis a no-op for versions already live.pypa/gh-action-pypi-publishalready runs withskip-existing: true, so re-runningpublish-pypiskips versions already uploaded instead of erroring.productionenvironment are unchanged.