feat(node-red): add media play/pause, next, and previous commands - #93
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 524fb6c9af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "node-red-contrib-teslemetry": minor | |||
There was a problem hiding this comment.
Use the scoped package name in the changeset
The workspace package is named @teslemetry/node-red-contrib-teslemetry, but this entry targets the nonexistent unscoped package node-red-contrib-teslemetry. When changesets/action assembles the release plan on main, it will reject the unknown package instead of creating the version PR, blocking the repository's release workflow until the key is changed to the scoped name.
AGENTS.md reference: AGENTS.md:L242-L250
Useful? React with 👍 / 👎.
Wires the vehicle-command node's switch to the existing SDK methods mediaTogglePlayback/mediaNextTrack/mediaPreviousTrack and adds their editor dropdown options, following the pattern of the other no-argument commands already in the node.
The workspace package is @teslemetry/node-red-contrib-teslemetry; the unscoped name would be rejected by changesets/action when assembling the release plan on main.
Intent
teslemetry-vehicle-commandwas missing media transport controls, even though@teslemetry/apialready exposes them.mediaTogglePlayback(Play/Pause),mediaNextTrack,mediaPreviousTrack.adjustVolumemedia command.startCharging/stopCharging/etc.