Skip to content

feat(node-red): add media play/pause, next, and previous commands - #93

Merged
Bre77 merged 2 commits into
mainfrom
fm/nred-t2-media
Aug 6, 2026
Merged

feat(node-red): add media play/pause, next, and previous commands#93
Bre77 merged 2 commits into
mainfrom
fm/nred-t2-media

Conversation

@Bre77

@Bre77 Bre77 commented Aug 6, 2026

Copy link
Copy Markdown
Member

Intent

  • Part of the tier-2 Node-RED parity wave (E1.4): teslemetry-vehicle-command was missing media transport controls, even though @teslemetry/api already exposes them.
    • Added three switch cases wired to the existing SDK methods: mediaTogglePlayback (Play/Pause), mediaNextTrack, mediaPreviousTrack.
    • Added matching dropdown options in the node's editor HTML, placed next to the existing adjustVolume media command.
    • No new abstractions - follows the same no-argument-command pattern already used for startCharging/stopCharging/etc.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 524fb6c9af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .changeset/media-playback-commands.md Outdated
@@ -0,0 +1,5 @@
---
"node-red-contrib-teslemetry": minor

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use the scoped package name in the changeset

The workspace package is named @teslemetry/node-red-contrib-teslemetry, but this entry targets the nonexistent unscoped package node-red-contrib-teslemetry. When changesets/action assembles the release plan on main, it will reject the unknown package instead of creating the version PR, blocking the repository's release workflow until the key is changed to the scoped name.

AGENTS.md reference: AGENTS.md:L242-L250

Useful? React with 👍 / 👎.

@Bre77 Bre77 added the fm Opened by a Firstmate crewmate label Aug 6, 2026
@Bre77
Bre77 marked this pull request as draft August 6, 2026 06:39
@Bre77
Bre77 marked this pull request as ready for review August 6, 2026 06:41
Bre77 added 2 commits August 6, 2026 17:49
Wires the vehicle-command node's switch to the existing SDK methods
mediaTogglePlayback/mediaNextTrack/mediaPreviousTrack and adds their
editor dropdown options, following the pattern of the other no-argument
commands already in the node.
The workspace package is @teslemetry/node-red-contrib-teslemetry;
the unscoped name would be rejected by changesets/action when
assembling the release plan on main.
@Bre77
Bre77 force-pushed the fm/nred-t2-media branch from 92b6873 to 5b96eda Compare August 6, 2026 07:50
@Bre77
Bre77 merged commit 3e1e7c9 into main Aug 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fm Opened by a Firstmate crewmate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant