fix: harden FortiFlow request boundaries and dependencies - #1
Merged
Conversation
Register upload and admin limiting before body parsing, support an explicit trusted proxy, and cover rate and upload boundaries with HTTP tests.
Upgrade the directly exposed upload and WebSocket dependencies to versions outside the audited vulnerable ranges.
Run npm audit with a critical threshold, block fixable critical Trivy findings, and document accepted and deferred security risks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
Ce lot corrige les findings de sécurité à forte valeur identifiés lors de l’audit FortiFlow, sans introduire d’authentification applicative ni modifier la limite métier des gros exports FortiAnalyzer.
Findings corrigés
express.json, Multer et les routes coûteuses ;/api/uploadet/api/admin;FORTIFLOW_TRUST_PROXY, vide par défaut ;X-Forwarded-Forfourni par le client.2.1.1→2.2.0.8.20.0→8.21.3.Accepted risks
Éléments deferred
.xls/.xlsxsuffisamment fiable ;Tests et résultats
npm test: 58/58 PASS ;node --check: PASS ;docker compose config: PASS ;npm audit --omit=dev: 11 → 9 vulnérabilités :Correctif CI après ouverture de la PR
37302a7 fix(ci): align runtime tests and base image security:infra/nginxest volontairement absent ;node:26.7.0-alpine3.24afin d’obtenir npm11.19.0ettar 7.5.19, version corrigeant CVE-2026-59873 ;tar 7.5.16; aucun contournement ou ignore Trivy n’a été ajouté.Résultats GitHub Actions finaux
node-tests: PASS ;docker-build: PASS ;security-scan: PASS ;publish-ghcr: SKIPPED attendu sur une Pull Request.Régressions
Aucune régression observée lors des tests locaux, de la CI et de la review indépendante.
Hors périmètre
Cette PR ne merge ni ne redéploie aucune stack Portainer.