fix(security): cover costly routes and pin Trivy - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
Corrige les deux findings FortiFlow confirmés lors de l’audit ciblé :
aquasecurity/trivy-actionsur le commit correspondant àv0.36.0.Aucune authentification applicative n’est ajoutée : la décision existante de protection par firewall/reverse proxy reste inchangée.
Findings
Rate limiter — FIXED
Routes couvertes en plus de
/api/uploadet/api/admin:/api/import/workspace;/api/import/policies-xlsx;/api/deploy/config-upload;/api/deploy/dynamic-routes.Les tests HTTP vérifient la couverture et la réponse
429avant les parseurs ou Multer.Trivy Action — FIXED
Les deux usages de
aquasecurity/trivy-actionsont épinglés au SHA :ed142fd0673e97e23eac54620cfb913e5ce36c25 # v0.36.0Ce SHA a été vérifié comme le commit pointé par le tag annoté
v0.36.0.Map du limiter — NOT REPRODUCED
Aucune correction : les buckets inactifs sont purgés périodiquement et aucune croissance permanente n’a été reproduite.
Tests
origin/main: quatre tests rate limiter et le contrôle Trivy échouent comme attendu ;npm test: 63/63 PASS sur l’hôte ;.githubet Nginx hors contexte applicatif) ;node --checkdes fichiers JavaScript modifiés : PASS ;npm audit --omit=dev --audit-level=critical: PASS, 0 CRITICAL ;git diff --check: PASS ;docker compose config: PASS ;/api/health: HTTP 200 ;node-tests,docker-buildetsecurity-scanPASS ;publish-ghcrskipped comme prévu sur une PR.Hors périmètre