Housekeeping: branch cleanup, kit sync, tracker sync - #359
Merged
Conversation
Qodo is retired; automated PR review now runs via the anthropics/claude-code-action GitHub Action.
Synced from af610a6 to e9e21bf (9 commits): adds /install-code-review-agent, the codex profile launcher and its tests, the design-state read/check/projection scripts and their tests, and updates the existing command cores and Sync-Kit/Test-Companion tooling. verify.md's core was Unmigrated-Blocked (this repo's gate table had no companion) — moved the table into verify-local.md under the gate-commands category the core declares, so the sync could take the core outright. Recorded in design/90-decisions.md.
…cal gate table engine/TODO.md and its compatibility pointer were stale against design/30-slices.md after the tracker sync — build/Test-Documentation.ps1 caught it. Also updated verify-local.md's gate-commands table: verify.yml no longer flags Test-Companion.ps1 or Test-DesignState.ps1 as CI gates.
15 discovered gates: 9 passed, 1 failed (Pester — the kit's self-referential design/state/ tests, not applicable to this repo's design/ shape), 5 did not run (docs.ps1 absent, NUGET_GITHUB_TOKEN unavailable locally). See PR #359's Verified section for the rendered report.
Cores taken outright: install-all.md, install-code-review-agent.md, kit-sync.md pick up the phase-4-step-8 wording sync from kit commits 1eca3dc/adcc76c/1bcfe36. The kit's own #109/#110 fix for the design-state self-tests bundles an S12.7 regression-guard block that assumes design/state exists in whatever repo the file runs in - this repo doesn't have it, so taking that file verbatim would fail S12.7's own assertion here. Kept this repo's existing equivalent -Skip: fix (already recorded in design/90-decisions.md, 2026-08-21) instead of overwriting it with the kit's file. kit.json commit bumped to 811bc96; syncedCommit already advanced by Sync-Kit.ps1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature/sync-main-status-b5d31e,slice/W78); leftfeature/bulgaria-arcs-expansion,slice/S1(closed, unmerged PRs) andreconcile/w71-w76-tracking(open PR Reconcile W71 landing, cover /authoring in consumer-smoke, and track W76 #316) alone per user decision. No local branches were eligible for deletion.design/30-slices.md, linking their closing issues (W78 — Localization Coverage and String Extraction #326-W74c — The Breaking Ownership Release #331) — all six had already merged (PRs W78 — Localization Coverage and String Extraction #340, W79 — What Changed Between Two Resolutions #342, W80 — Seeing a Story Graph #343, W81 — Construction Finishes What build Starts #345, W82 — A Kiosk That Ran Out Can Be Refilled #347, W83 — Buildings Get Dirty, Wear Out, and Break #348) but the tracker still showed "Not started".qodo-code-reviewreference in the required-checks note now that automated PR review runs viaanthropics/claude-code-action(Qodo is retired).~/.agent-kitfromaf610a6toe9e21bf(9 commits) and reconciled command cores/tools into this repo.verify.md's core wasUnmigrated-Blocked(this repo's gate table had no companion); resolved by moving the table into.claude/commands/verify-local.mdunder thegate-commandscategory the core declares, recorded indesign/90-decisions.md.engine/TODO.mdand its compatibility pointer stale againstdesign/30-slices.md;build/Test-Documentation.ps1caught it, so./build/ConvertTo-HumanDocumentation.ps1was re-run and the output committed. Also refreshedverify-local.md's gate table —verify.ymlno longer flagsTest-Companion.ps1/Test-DesignState.ps1as CI gates, discovered while re-deriving the gate list from the workflow files rather than trusting the memorized one.Verified
Ran and passed:
npm --prefix src/engine run typecheck, exit 0npm --prefix src/engine run lint, exit 0npm --prefix src/engine test(vitest) — 79/79 test files, 1127/1127 testsnpm pack --silentproducedthe-running-dev-game-engine-0.10.0.tgzsrc/, notsconfig*.json, no.test.*entries;package/dist/presenttools/*.ps1parses clean./build/Test-Documentation.ps1: drift check passed across 18 generated engine pages, compatibility pointers and the guide; 123 Markdown files checkednpm --prefix src/engine run build+npm --prefix site run check(format/lint/typecheck/test/browser/build/merge) all greenRan and failed:
Invoke-Pester -Path tools: 241/253 passed, 12 failed. All 12 are in the newly kit-syncedRead-DesignState.Tests.ps1/Test-DesignState.Tests.ps1/Test-CIWorkflow.Tests.ps1/Update-DesignProjection.Tests.ps1— self-referential tests (Split-Path $PSScriptRoot -Parent) that validate the agent-kit's own dogfoodeddesign/state/per-unit-record mechanism and itsverify.ymlshape against whatever repo they're copied into. This repo'sdesign/uses00-brief/10-design/20-contract/30-slices/90-decisions, not the kit'sdesign/state/scheme, so these fail structurally (StateSetAbsent) rather than from a regression — the same gapTest-DesignState.ps1itself reports as exit 2 when run directly here. Full failing-test list and detail in.claude/verify-report.json.Did not run:
docs.ps1is absent from this checkout (CLAUDE.md: installer-generated viaInvoke-SetupDocs, not committed); needs Docker and an installeddocs.ps1, neither set up this sessionartifacts/docsoutput of "Build documentation" above, which didn't rundotnet testneedsNUGET_GITHUB_TOKENfor the sibling-repo NuGet feed, not set locallyAgent detail
/kit-sync, tracker sync) plus the doc-drift fix it surfaced.claude/verify-report.json: validated bytools/Test-VerifyReport.ps1(Valid, 15 gates, 0 findings, 0 could-not-evaluate) before this section was rendered from it