Skip to content

fix(sorts): prevent comb_sort from returning an unsorted list #15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SEPURI-SAI-KRISHNA wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −3
Open

fix(sorts): prevent comb_sort from returning an unsorted list #15003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sorts/comb_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,19 @@ def comb_sort(data: list) -> list:
[]
>>> comb_sort([99, 45, -7, 8, 2, 0, -15, 3])
[-15, -7, 0, 2, 3, 8, 45, 99]
>>> comb_sort([2, 0, 3, 4, 5, 6, 1])
[0, 1, 2, 3, 4, 5, 6]
"""
shrink_factor = 1.3
gap = len(data)
completed = False

while not completed:
# Update the gap value for a next comb
gap = int(gap / shrink_factor)
if gap <= 1:
# Update the gap value for a next comb. The gap is never allowed to drop
# below 1: a gap of 0 compares each element with itself, so no swap can
# ever happen and the loop would exit while the data is still unsorted.
gap = max(int(gap / shrink_factor), 1)
if gap == 1:
completed = True

index = 0
Expand Down