on-the-fly rotation tracker following ParticlesMC architecture#78
Merged
V-Francois merged 17 commits intoJun 2, 2026
Merged
Conversation
…to look like Arianna
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
romainljsimon
left a comment
Member
There was a problem hiding this comment.
I like this version a lot, thanks @cyfraysse for the nice PR!
Let's wait for the StoreLastPhiFrame method before merging the PR :)
Member
|
I was also thinking we could change the |
V-Francois
reviewed
Jun 1, 2026
V-Francois
left a comment
Contributor
There was a problem hiding this comment.
Great stuff, I just have a few minor comments.
Could you maybe add a test in the test folder that runs this? Just to have an end-to-end working case.
… to correction during the PR and fixed them
Contributor
Author
|
I've added the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new algorithms
1-
ComputeRotation—>[[simulation.observable]]system.phiat every compute steptheta_Tconvention:0.0→ Integral (relay every step)π→ Euler (compare to initial frame)R0,R_ref,phi_acc) kept inRotationState, one per chain2-
StorePhiTrajectories—>[[simulation.output]]system.phiand writes to disk on its schedulerchains/1/phitrajectories_k.datKey design decisions
system.phiadded toMoleculesstruct right afterposition— rotation vectors live on the system like positions[[simulation.observable]]TOML section for non-output algorithmsTOML usage
Note: depends on TheDisorderedOrganization/Arianna.jl#87