Skip to content

New scheduler building logic ; Arianna.jl dependency to v0.2.1#79

Open
cyfraysse wants to merge 12 commits into
TheDisorderedOrganization:mainfrom
cyfraysse:feature/scheduler
Open

New scheduler building logic ; Arianna.jl dependency to v0.2.1#79
cyfraysse wants to merge 12 commits into
TheDisorderedOrganization:mainfrom
cyfraysse:feature/scheduler

Conversation

@cyfraysse

Copy link
Copy Markdown
Contributor

This PR is using Arianna.jl new dependency which introduces a new way to schedule outputs in simulation.

Created the build_sched(scheduler_params, steps, burn) helper function to eliminate duplicated if/else structures block for observables and outputs.
The new scheduler is called in TOML by the keyword : multi_origins.
e.g : scheduler_params = {multi_origins = {tmax = x , tw = y , N = z}}

@cyfraysse cyfraysse requested a review from a team as a code owner June 3, 2026 08:00
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ParticlesMC.jl 0.00% 13 Missing ⚠️
Files with missing lines Coverage Δ
src/rotation.jl 99.34% <100.00%> (ø)
src/ParticlesMC.jl 7.14% <0.00%> (-0.18%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/ParticlesMC.jl Outdated

@romainljsimon romainljsimon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment I made, I like the PR, thanks @cyfraysse

Comment thread src/ParticlesMC.jl Outdated
Comment thread src/ParticlesMC.jl Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants