-
Notifications
You must be signed in to change notification settings - Fork 218
feat: optional password + Authenticator number-match login #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,11 @@ | |
|
|
||
| # Account 1 | ||
| ACCOUNT_1_EMAIL=email@example.com | ||
| ACCOUNT_1_PASSWORD=your_password | ||
| # Password is optional. Leave blank/unset to sign in with: | ||
| # - Microsoft Authenticator approval (passwordless / number match) | ||
| # - Email code (prompted in the terminal) | ||
| # - TOTP authenticator (set ACCOUNT_1_TOTP_SECRET) | ||
| #ACCOUNT_1_PASSWORD= | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Definitely do no comment out password, since it's by far the most used login method. You can just leave it as in and blank for those who don't use it. Having it say optional is fine however. |
||
| #ACCOUNT_1_TOTP_SECRET= | ||
| #ACCOUNT_1_RECOVERY_EMAIL= | ||
| #ACCOUNT_1_GEO_LOCALE=auto | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| "author": "Netsky", | ||
| "license": "GPL-3.0-or-later", | ||
| "engines": { | ||
| "node": ">=24.0.0" | ||
| "node": ">=22.0.0" | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's no switch back to 22.x, due to some changes in node this has been set to 24.x for a reason. I also don't know what this has to do with this PR. |
||
| }, | ||
| "scripts": { | ||
| "pre-build": "npm i && rimraf dist && npx patchright install chromium", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,3 +67,11 @@ export async function getErrorMessage(page: Page): Promise<string | null> { | |
| const text = await errorAlert.innerText() | ||
| return text.trim() | ||
| } | ||
|
|
||
| /** Microsoft Authenticator number-match / approve-on-phone prompts (not email OTP). */ | ||
| export function isPasswordlessNumberMatchMessage(message: string | null | undefined): boolean { | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid language dependant selectors/regex for the login, these tend to change for the user's region. These are avoided wherever possible. See if you can find another way to detect this. |
||
| if (!message) return false | ||
| return /select this number|sign-in request on your (mobile )?device|approve.*(authenticator|notification)|open your authenticator/i.test( | ||
| message | ||
| ) | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't related to this PR, there's also no explanation why you're now adding these to the dockerignore file?