perf+feat: Morse hot path, Metatomic keys (#215), ASE srun (#193)#355
Merged
Conversation
Morse pair force: inline hot path with loop-invariant constants and pointer Fi (same MIC, cutoff, and fmag/r as before). Metatomic: energy_output and energy_uncertainty_output in INI and schema; explicit uncertainty key missing from the model aborts construction when uncertainty checks are enabled (issue 215). ASE NWChem: mpi_launcher (mpirun default or srun) for Slurm (issue 193).
HaoZeke
force-pushed
the
restore/morse-metatomic-ase
branch
from
bbf8818 to
4686bc4
Compare
eOn Documentation PreviewDownload: documentation.zip Unzip and open |
Add energy_output, energy_uncertainty_output, and mpi_launcher to config.yaml and schema so ConfigClass validation matches the C++ INI loader.
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores work from closed #353 (develop was FF to main for #354). See #353 for prior Claude/Codex review; Metatomic explicit uncertainty key hard-fails.