fix: Per message setting of response time limit#72
Open
rustybee42 wants to merge 1 commit into
Open
Conversation
rustybee42
force-pushed
the
rb/receive-time-limit
branch
from
a8caaef to
c2b2dd0
Compare
Add a new associated const to the Msg trait that defines how long to wait for this message when receiving it as a response. To achieve this, make the timeout setting for stream writes and reads a function argument and pass the message specific time limit (default: 2s). For GetQuotaInfoResp, set this to 40m. This should fix running into timeouts while fetching quota if the storage server needs a long time to process the request.
rustybee42
force-pushed
the
rb/receive-time-limit
branch
from
c2b2dd0 to
437356a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new associated const to the Msg trait that defines how long to wait for this message when receiving it as a response.
To achieve this, make the timeout setting for stream writes and reads a function argument and pass the message specific time limit (default: 2s).
For GetQuotaInfoResp, set this to 40m. This should fix running into timeouts while fetching quota if the storage server needs a long time to process the request.
Closes https://github.com/ThinkParQ/beegfs-core/issues/4618