feat: Add deny-by-default module allowlist - #5
Merged
Conversation
Gate require behind an explicit allowedModules list on both the in-process and worker_threads tiers. Paths are always refused; bare and node: ids match.
ThomasHartDev
commented
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an explicit allowedModules option so untrusted code only gets require when the caller opts in. Empty list still injects a require that denies everything; a non-empty list is exact-match only with bare and node: treated as the same id. Relative and absolute paths are dropped from the allowlist and refused at load time so nothing reopens filesystem resolution through a sneaky entry. Wired into both run and runInWorker, and the allowlist gate wins over a grant-supplied require so you cannot accidentally hand in the full host loader while meaning to restrict it. Had a small gotcha on the worker tier where freezeRealm freezes Error.prototype and a plain err.name assignment blows up, so the gate sets the error name with defineProperty instead.