Rewrite Slack markdown tables before delivery - #50
Open
fineas-bot[bot] wants to merge 1 commit into
Open
Conversation
Slack does not render GitHub-style pipe tables, so final answers that use markdown tables show up in Slack as raw pipes and long rows. Normalize markdown pipe tables in Slackbot v2 output into Slack-friendly bullet groups across live streaming, recovered streaming, fallback, and plain-text final delivery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: Slackbot v2 streamed final answers as Chat SDK
markdown_textwithout adapting GitHub-style pipe tables. Slack does not render those tables, so replies like the Attio lead update inslack:C0B7WSP2NCB:1782400644.013719show up as raw pipe-delimited rows and long URLs. The earlier native-table work was the inverse path: ingesting Slack native table blocks into context, not rendering outgoing Markdown tables back to Slack.Fix:
Validation:
| Lead | Attio record | Task |text reached the Slack stream.bun test test/chat-sdk-emulate.test.ts -t "rewrites markdown pipe tables"bun test test/chat-sdk-emulate.test.tsbun tsgo --project tsconfig.json --noEmitbun test testRelated/overlap: PR #36 also touches Slackbot v2 files, but handles incoming Slack native table ingestion. This PR fixes outgoing final-answer rendering.