refactor(app): workbench 独立为 @agenthub/workbench 包 (#1759 第二阶段) - #1832
Open
DeliciousBuding wants to merge 3 commits into
Open
refactor(app): workbench 独立为 @agenthub/workbench 包 (#1759 第二阶段)#1832DeliciousBuding wants to merge 3 commits into
DeliciousBuding wants to merge 3 commits into
Conversation
|
Important Review skippedToo many files! This PR contains 424 files, which is 324 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (424)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DeliciousBuding
force-pushed
the
refactor/1759-workbench-package
branch
3 times, most recently
from
August 21, 2026 10:56
1461bc7 to
d05894a
Compare
DeliciousBuding
added a commit
that referenced
this pull request
Aug 21, 2026
#1832 大 PR(>300 文件)触发 golangci-lint-action 全量回退, 17 条已登记 baseline 的复杂度发现直接 fail 阻塞合并。原 Lint step 的退出码不读 baseline,无法豁免;把硬门禁移到 fingerprint ratchet step(读同一份 JSON 报告),Lint step 降为 report-only。baseline (scripts/verify/hub-lint-baseline.json)已含全部 17 条 fingerprint, 无需增删;本 commit 仅改门禁接线与 verify-ci-gates 断言。 Co-authored-by: Cursor <cursor@vectorcontrol.tech>
DeliciousBuding
added a commit
that referenced
this pull request
Aug 21, 2026
#1832 大 PR(>300 文件)触发 golangci-lint-action 全量回退, 17 条已登记 baseline 的复杂度发现直接 fail 阻塞合并。原 Lint step 的退出码不读 baseline,无法豁免;把硬门禁移到 fingerprint ratchet step(读同一份 JSON 报告),Lint step 降为 report-only。baseline (scripts/verify/hub-lint-baseline.json)已含全部 17 条 fingerprint, 无需增删;本 commit 仅改门禁接线与 verify-ci-gates 断言。 Co-authored-by: Cursor <cursor@vectorcontrol.tech>
DeliciousBuding
added a commit
that referenced
this pull request
Aug 21, 2026
#1832 大 PR(>300 文件)触发 golangci-lint-action 全量回退, 17 条已登记 baseline 的复杂度发现直接 fail 阻塞合并。原 Lint step 的退出码不读 baseline,无法豁免;把硬门禁移到 fingerprint ratchet step(读同一份 JSON 报告),Lint step 降为 report-only。baseline (scripts/verify/hub-lint-baseline.json)已含全部 17 条 fingerprint, 无需增删;本 commit 仅改门禁接线与 verify-ci-gates 断言。 Co-authored-by: Cursor <cursor@vectorcontrol.tech>
DeliciousBuding
added a commit
that referenced
this pull request
Aug 21, 2026
…1829) * ci(checks): go-edge/go-hub 恒报 report 修复纯前端 PR 的 required check 跳过阻塞 Co-authored-by: Cursor <cursor@vectorcontrol.tech> * docs(verify): ci-gates 恒报断言补充 docstring (#1829) Co-authored-by: Cursor <cursor@vectorcontrol.tech> * ci(hub): lint 硬门禁改由 #1573 ratchet 承担,全量回退模式豁免 17 条存量 #1832 大 PR(>300 文件)触发 golangci-lint-action 全量回退, 17 条已登记 baseline 的复杂度发现直接 fail 阻塞合并。原 Lint step 的退出码不读 baseline,无法豁免;把硬门禁移到 fingerprint ratchet step(读同一份 JSON 报告),Lint step 降为 report-only。baseline (scripts/verify/hub-lint-baseline.json)已含全部 17 条 fingerprint, 无需增删;本 commit 仅改门禁接线与 verify-ci-gates 断言。 Co-authored-by: Cursor <cursor@vectorcontrol.tech> * ci(hub): quality-debt baseline 跟进 Lint 降 advisory 的 soft_gate 迁移 Co-authored-by: Cursor <cursor@vectorcontrol.tech> * ci(verify): go 恒报 fallback 增加 changes 失败 fail-closed changes job 失败时 outputs.go 为空,fallback 原条件会误报成功; 现要求 changes.result=='success',失败时新增 step exit 1 防 false green。 Co-authored-by: Cursor <cursor@vectorcontrol.tech> --------- Co-authored-by: DeliciousBuding <DeliciousBuding@users.noreply.github.com> Co-authored-by: Cursor <cursor@vectorcontrol.tech>
DeliciousBuding
force-pushed
the
refactor/1759-workbench-package
branch
from
August 21, 2026 13:14
f5d5698 to
c51c9ae
Compare
Co-authored-by: Cursor <cursor@vectorcontrol.tech>
Co-authored-by: Cursor <cursor@vectorcontrol.tech>
Co-authored-by: Cursor <cursor@vectorcontrol.tech>
DeliciousBuding
force-pushed
the
refactor/1759-workbench-package
branch
from
August 21, 2026 14:32
c51c9ae to
d27a780
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
#1759 第二阶段:把
app/shared/src/workbench整棵子树(约 370 个文件)独立为前端 monorepo 第 6 个包@agenthub/workbench,消除 shared 内 workbench 与其它子树的双向纠缠,固定依赖方向为 workbench → shared 单向。迁移方案
app/shared/src/workbench→app/workbench/src,相似度 97-100%),48 个文件导入/配置修改。@agenthub/workbench@0.5.0(private),exports 暴露./hubDataMapping/pages/designIcons/desktopChromeEvents/WorkbenchRoutes,peerDeps react/react-dom/react-i18next,依赖@agenthub/shared。@shared/workbench重写为@agenthub/workbench(含@agenthub/workbench/hubDataMapping深导入)。scripts/verify/verify-frontend-package-boundary.py(+ 6 个负向自测):shared 不得 import workbench;workbench 不得引用 desktop/web/mobile-rn 端包,越界相对导入只能落 shared。已接入 checks.yml。verify-shared-boundary.py扫描根从app/shared/src/workbench切到app/workbench/src;docs/verifier-map 同步。验证输出
pnpm install --frozen-lockfile@agenthub/workbenchtypecheck@agenthub/workbenchtestagenthub-webtypecheck(消费方)verify-frontend-package-boundary.pyverify-shared-boundary.pyverify-doc-ssot.py@shared/workbench→ typecheck 抓出 TS2307,已还原统计
421 files changed, +1163/−595(364 rename + 48 modify + 9 new)。
Closes #1759