Draft
Fix format_as wrapping strings in double quotes + add unit tests#23
Conversation
Co-authored-by: TonyWelte <12954392+TonyWelte@users.noreply.github.com>
Co-authored-by: TonyWelte <12954392+TonyWelte@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
TonyWelte
August 24, 2026 19:20
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_aswas usingj.dump()unconditionally, which wraps JSON string values in double quotes. This caused include path lookups to fail (e.g."msg"/UUID.jsoninstead ofmsg/UUID.json).Changes
format_as(const json&): usej.get<std::string>()for string values, fall back toj.dump()for all other typesformat_as(const detail::iter_impl<const json>&): delegate to the value overload viaformat_as(*j)for consistencyrosidlcpp_generator_core/test/unit/covering both overloads: string values are returned unquoted, non-string types (int, bool, null, array, object) continue to usedump()format