chore: bump go-didcomm to v0.5.0 - #9
Merged
Merged
Conversation
thomasjsk
marked this pull request as ready for review
July 8, 2026 19:34
Apply go-didcomm v0.5.0 upgrade (patch from Milo). The module path lowercases to github.com/notabene-id/go-didcomm and is pinned at the pseudo-version v0.4.1-0.20260708110526-ba45976d2288. go-didcomm's Unpack now returns (*Message, *Metadata, error) and adds UnpackUnverified. Adapt the TAP Client accordingly: - Client.Receive now authenticates the sender; plain and anonymously-encrypted messages are rejected. - Add Client.ReceiveUnverified for callers that accept unverified senders. - TAPResult drops Signed, gains SenderDID; Anonymous is derived from an empty SenderDID. Also refactors the CLI (new cmd/tap/support.go, reworked receive) and updates CHANGELOG, README, and CLAUDE.md for the new module path and API.
thomasjsk
force-pushed
the
chore/bump-go-didcomm-0.5.0
branch
from
July 8, 2026 19:35
9a46329 to
b00d9c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
github.com/notabene-id/go-didcomm, pinned at the pseudo-versionv0.4.1-0.20260708110526-ba45976d2288— not a taggedv0.5.0release, despite the patch filename. Worth confirming that's the intended pin before this lands.Unpacknow returns(*Message, *Metadata, error)and addsUnpackUnverified.API impact (breaking)
Client.Receivenow authenticates the sender — plain and anonymously-encrypted messages are rejected. Callers that relied on accepting those must switch to the newClient.ReceiveUnverified.TAPResult:SignedSenderDID(cryptographically verified sender, empty when unverified)Anonymousis now derived from an emptySenderDID, not carried separately.Also in the patch
cmd/tap/support.go.Local
go build/go vet/golangci-lint(0 issues) /go test ./...all pass.