add missing default value for SubscriptionRenewal#223
Merged
Conversation
haeckerbaer
requested review from
Aurige,
BredeD,
TuThoThai,
Ulf9,
skinkie,
thbar,
tim-rivett and
ue71603
haeckerbaer
added
general
tim-rivett
previously approved these changes
Jun 9, 2026
skinkie
previously requested changes
Jun 10, 2026
tim-rivett
previously approved these changes
Jun 18, 2026
ue71603
previously approved these changes
Jun 18, 2026
Collaborator
Author
|
@skinkie does the updated description work for you? |
github-actions
Bot
dismissed stale reviews from tim-rivett and ue71603
via
512460f
skinkie
approved these changes
Jul 6, 2026
ue71603
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed and decided during SG7 meeting on 25.03.2026:
The element in question was introduced in v2.1 and doesn't have an explicit default value (only hinted in the annotation). At the time we discussed the removal of default values but all of these alternative approaches were scrapped before the release of v2.1. It seems that we missed to update SubscriptionRenewal accordingly. Harmonization with the other request parameters (that have default values) is necessary.