Added test for World::updateGameStateBall(const Ball &ball) in software/world/world.cpp

[aakaashsenthilkumar]

Description

Added test TEST_F(WorldTest, update_game_state_ball) for World::updateGameStateBall(const Ball &ball) in software/world/world.cpp

Testing Done

Test TEST_F(WorldTest, update_game_state_ball) ran successfully.

Resolved Issues

resolves #1682 

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

• Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
• Remove all commented out code
• Remove extra print statements: for example, those just used for testing
• Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

[StarrryNight]

Good work! Interestingly 'updateGameStateBall' is not called anywhere in the code. We might need to look into its actual usage.

[nycrat]

Good work! Interestingly 'updateGameStateBall' is not called anywhere in the code. We might need to look into its actual usage.

The method was originally added in this commit: dcb9c16 and the one file that used it has been removed. I think we opt to use the World::updateBall method instead since the implementations are the same except it also updates the timestamp and ball_ variable.

Perhaps we should instead remove this old method as it might cause issues because it doesn't update the timestamp and ball_ as expected