Kalman Filter Tests#3736
Open
adrianchan787 wants to merge 7 commits into
Open
Conversation
nycrat
approved these changes
May 30, 2026
Member
nycrat
left a comment
There was a problem hiding this comment.
Great work! I know some of the tests have lots of boilerplate, especially with the Eigen library. I think it's fine to leave it like this cause it would be quite difficult to re-write and somehow communicate the meanings of each value supplied into these matrices. The comments are good for explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kalman Filter mathematical and behavioural unit tests.
Split the tests up into 1-D, 2-D, 3-D.
Rough partitioning for behaviour:
(please lmk if there's any more tests worth adding)
Testing Done
Tests pass so far.
Resolved Issues
resolves #3727
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issueIf needed I can comment on the derivation of the mathematical equations.