Skip to content

Add Elaine Wang profile to team page - #77

Open
imelainew wants to merge 12 commits into
UCD-SERG:mainfrom
imelainew:main
Open

Add Elaine Wang profile to team page#77
imelainew wants to merge 12 commits into
UCD-SERG:mainfrom
imelainew:main

Conversation

@imelainew

Copy link
Copy Markdown

Adding my profile to the lab team page as requested.

Changes:

  • Added people/yxewang/bio-yxewang.qmd (bio)
  • Added people/yxewang/yxewang.jpg (profile photo)
  • Updated team.qmd to include my entry in the lab-member list

@imelainew
imelainew requested a review from kaiemjoy June 30, 2026 19:52
Comment thread people/yxewang/bio-yxewang.qmd Outdated
Co-authored-by: Kristen Aiemjoy <16113030+kaiemjoy@users.noreply.github.com>
Elaine is a 1st year MS student in the Applied Mathematics program at UC Davis. Her current research focuses on developing the `serodynamics` R package, which extends the Serocalculator framework to support broader seroepidemiological modeling of antibody dynamics. Her research interests lie at the intersection of statistical and mathematical modeling and infectious disease epidemiology, with a focus on disease forecasting and prevention in global health settings.

Email: yxewang@ucdavis.edu

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
possibly add github id

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

Comment thread people/yxewang/bio-yxewang.qmd Outdated
institution: "UC Davis"
---

Elaine is a 1st year MS student in the Applied Mathematics program at UC Davis. Her current research focuses on developing the `serodynamics` R package, to support broader seroepidemiological modeling of post-infection antibody dynamics. Her research interests lie at the intersection of statistical and mathematical modeling and infectious disease epidemiology, with a focus on disease forecasting and prevention in global health settings.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Elaine is a 1st year MS student in the Applied Mathematics program at UC Davis. Her current research focuses on developing the `serodynamics` R package, to support broader seroepidemiological modeling of post-infection antibody dynamics. Her research interests lie at the intersection of statistical and mathematical modeling and infectious disease epidemiology, with a focus on disease forecasting and prevention in global health settings.
Elaine is a 1st year MS student in the Applied Mathematics program at UC Davis. Her current research focuses on developing the `serodynamics` R package, to support broader seroepidemiological modeling of post-infection antibody dynamics. Her research interests lie at the intersection of statistical and mathematical modeling and infectious disease epidemiology, with a focus on disease forecasting and prevention in global health settings.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@imelainew
imelainew requested a review from kaiemjoy July 1, 2026 01:01
@imelainew

Copy link
Copy Markdown
Author

Thanks! Both suggestions applied. Ready for re-review.

@imelainew

Copy link
Copy Markdown
Author

@kaiemjoy just a gentle bump — ready for re-review whenever you have time!

@kaiemjoy kaiemjoy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks Elaine

@imelainew

Copy link
Copy Markdown
Author

@claude review the error

@claude

claude Bot commented Jul 30, 2026

Copy link
Copy Markdown

Claude Code is working…

I'll analyze this and get back to you.

View job run

d-morrison pushed a commit to imelainew/ucd-serg.github.io that referenced this pull request Aug 1, 2026
rossjrw/pr-preview-action v1 does not support fork PRs: the
GITHUB_TOKEN issued for pull_request events from forks is read-only
and cannot push to gh-pages, so the deploy step always fails with a
403 for those PRs (e.g. PR UCD-SERG#77 from imelainew's fork). Skip the whole
job when the PR head repo isn't this repo instead of failing CI.
d-morrison pushed a commit to imelainew/ucd-serg.github.io that referenced this pull request Aug 1, 2026
claude-code-review.yml can't work for fork PRs: pull_request events
from forks never receive an OIDC token at all (GitHub never sets
ACTIONS_ID_TOKEN_REQUEST_URL for them, regardless of id-token: write -
confirmed on PR UCD-SERG#77, run 30686460528/job/91333167166), and switching to
pull_request_target doesn't help either since Anthropic's token-exchange
endpoint rejects OIDC tokens minted under that event (UCD-SERG#89,
anthropics/claude-code-action#713). issue_comment is subject to neither
restriction. Add a workflow, gated to OWNER/MEMBER/COLLABORATOR
commenters, that a maintainer can trigger with "@claude review" on any
PR - fork or not - to get the same review claude-code-review.yml gives
same-repo PRs.

Copy link
Copy Markdown
Member

@claude review


Generated by Claude Code

@claude

claude Bot commented Aug 1, 2026

Copy link
Copy Markdown

Claude Code is working…

I'll analyze this and get back to you.

View job run

@kaiemjoy kaiemjoy self-assigned this Aug 20, 2026
@kaiemjoy
kaiemjoy requested a review from d-morrison August 20, 2026 03:13
d-morrison added a commit that referenced this pull request Aug 24, 2026
Fixes a blocking defect introduced by the previous round's own fix, and a
factual claim I published in three places.

- BLOCKING: the dispatch always passed `--ref "$PR_BRANCH"`, and a
  workflow_dispatch runs the workflow file as it exists at that ref. This PR
  is what ADDS the workflow_dispatch trigger, so every branch cut before it
  lacks it -- three of the four open same-repo PRs. Either the dispatch is
  rejected and `set -e` kills the step before the acknowledgment posts, or
  it runs a copy that selects no job and the acknowledgment posts anyway,
  reintroducing the false promise the fork short-circuit was added to
  prevent. Now tries the PR branch, falls back to a no-ref dispatch, and
  acknowledges only if one actually started a run -- reporting the failure
  on the PR otherwise. Removing upstream's REF_ARGS array last round had
  also removed the only no-ref path, which is what left a deleted head
  branch with no fallback.
- FACTUAL: "it never executed once (5/5 runs skipped)" was wrong. That came
  from reading `--limit 5` and generalizing to the population. The real
  history is 25 runs: 23 skipped, one still in flight, and one success --
  run 30687108541 on 2026-08-01, against fork PR #77, the exact case the
  workflow was written for. It executed and posted nothing because its
  prompt never carried `--comment` (#96), which #97 fixed for the other
  review workflow and never for this one. The justification for deleting it
  is that it was non-functional, not that it never ran.
- FACTUAL: the user-facing fork notice blamed the OIDC exchange. That is the
  `pull_request`-path story (#90); a dispatched run executes in base-repo
  context with no fork token involved, and upstream describes its guard as
  failing a mistaken dispatch fast rather than closing a hole.
- "produces no run at all" corrected -- a skipped run is still recorded.
- `pull-requests: read` restated as declared rather than required, since a
  public repo would permit the read anyway.
- The `pull-requests: write` rationale covered only the pull_request
  trigger; added what bounds the workflow_dispatch path.
- Disambiguated "Set this to true", which sat five lines from its referent
  with `require-review` as the nearer antecedent, and split the three
  unrelated paragraphs sharing one heading.
- report-cost's description corrected to "appends".

Refs #101
@d-morrison

Copy link
Copy Markdown
Member

/review

@d-morrison

Copy link
Copy Markdown
Member

@claude review

@github-actions

Copy link
Copy Markdown
Contributor

👀 Picked up by workflow run #32804452985. Setup runs first; Claude itself responds after that.

@d-morrison

Copy link
Copy Markdown
Member

Code review (stand-in)

Posted in response to the review request on this thread. The repo's automated reviewer cannot reach this PR by any trigger: it is a fork PR, and both the pull_request path (OIDC withheld) and the dispatch path (job gate) skip forks -- tracked in #90. Today's request exercised the whole chain (mention -> agent -> dispatch -> review run) and the review job skipped by design, so this review stands in.

Reviewed commit: c19a04b960ed3b9bf472cb02748d1ab83e187c1d (the PR head, cross-verified as the head_sha of the passing Spellcheck run). No preview build exists for this PR (fork PRs get no build-deploy), so rendering claims below are verified from source and repo conventions rather than a built page.

The content is in good shape. kaiemjoy's suggestions were verified applied at the current head rather than taken from the "addressed" replies: the bio paragraph matches the corrected suggestion verbatim, and the requested GitHub id is present and resolves. The 2026-07-30 approval covers the current content -- every commit since is a main sync, and the blob SHAs of both profile files are byte-identical between the approved commit and head. Frontmatter matches what _ejs/people-box.ejs consumes, field-for-field with sibling profiles; lastname: "Wang" sorts correctly; alt text truthfully describes the portrait; the touch set is complete (profile + team.qmd, nothing else references siblings); and the fork branch is ahead 12 / behind 0 against upstream, touching no workflow files, so merge cannot regress the migrated CI.

1. people/yxewang/yxewang.jpg is 1.01 MB for an image rendered at 250 px

Measured: 1,038,032 bytes, 1312x1640 px. It is the largest profile image in the repo -- siblings run 12 KB to 654 KB -- and _ejs/people-box.ejs emits the raw src with no thumbnailing, so every /team.html visitor downloads the full file. This one image nearly doubles the Students-grid payload (~1.27 MB to ~2.3 MB).

Fix is one command before merge: magick yxewang.jpg -resize x800 -quality 82 yxewang.jpg (or sips -Z 800 yxewang.jpg), which keeps 2x sharpness at the 250 px render and typically lands under 150 KB.

2. The Email: and GitHub: lines will render as one run-on line

people/yxewang/bio-yxewang.qmd lines 13-14: the two lines are separated by a soft break only (no blank line, no trailing-space hard break, and _quarto.yml enables no hard-line-breaks extension), so Pandoc renders them as a single paragraph line: Email: yxewang@ucdavis.edu GitHub: ... with no separator. The two-line source layout indicates two display lines were intended.

Fix: a blank line between them (kvaidya's one-item-per-paragraph shape), or join them deliberately with a | separator as skang's profile does.

Candidates considered and dropped

"1st year MS student" going stale at the academic-year rollover (sibling profiles use identical phrasing; profiles are maintained by edits, not blocked in review); the comma in "R package, to support" (it is the approving reviewer's own applied suggestion text); linking the serodynamics repo (nice touch, but no sibling links projects); the PR coming from the fork's main rather than a feature branch (a workflow wart for future PRs, not actionable here); WORDLIST additions (none needed; Spellcheck passes at head).

Verdict: Needs more work

Both findings are small and localized -- a one-command recompression and a one-line Markdown fix -- and nothing else blocks. Push the two fixes to the fork branch (or defer finding 1 to a tracked issue and fix finding 2 in-line) and this is mergeable.

One note for whoever merges: the ruleset requires build-deploy, which skips on fork PRs, so this PR can never satisfy the required checks by itself -- merging will need the same admin path used for recent workflow PRs. That is #90's territory, not a defect of this PR.


Review generated by Claude Code and posted on Doug Morrison's behalf, standing in for the automated reviewer that cannot run on fork PRs (#90).

@d-morrison
d-morrison removed their request for review August 25, 2026 04:44
@imelainew
imelainew requested a lite review from Copilot August 26, 2026 03:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new lab member profile (Elaine Yuxuan Wang) and wires it into the existing Quarto-based team listing so it appears on the Team page.

Changes:

  • Added a new bio page at people/yxewang/bio-yxewang.qmd with front matter compatible with the existing people templates.
  • Added a profile photo at people/yxewang/yxewang.jpg and referenced it from the bio.
  • Updated team.qmd to include the new bio in the lab-member listing contents.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
team.qmd Adds the new bio file to the lab-member listing so the profile appears on the Team page.
people/yxewang/bio-yxewang.qmd Introduces Elaine’s profile page (front matter + bio content) in the established format.
people/yxewang/yxewang.jpg Adds the portrait image referenced by the new bio page.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants