Skip to content

Temporarily enable show_full_output on claude-review (diagnostic) - #93

Merged
d-morrison merged 1 commit into
mainfrom
claude/claude-review-debug-output
Aug 1, 2026
Merged

Temporarily enable show_full_output on claude-review (diagnostic)#93
d-morrison merged 1 commit into
mainfrom
claude/claude-review-debug-output

Conversation

@d-morrison

Copy link
Copy Markdown
Member

Summary

  • Follow-up to Allow claude-review to actually post its comment/inline review #92. That fix dropped permission_denials_count from 17 → 1 (confirmed on PR #87, run 30684616369), but the review still isn't posted — still No buffered inline comments and zero claude comments/reviews on the PR.
  • claude-code-action hides Claude's detailed tool-call stream by default ("full output hidden for security"), so there's no way to see which specific call the remaining single denial corresponds to from the log alone — only the count.
  • This PR temporarily sets show_full_output: true so the next run's log reveals the exact blocked tool call, so the actual fix (extending --allowed-tools correctly) can be targeted instead of guessed.

This is a diagnostic-only change — intent is to revert show_full_output once the cause is identified.

Test plan

  • After merge, trigger claude-review on a same-repo PR and inspect the verbose log for the specific denied tool call
  • Follow up with a fix PR for that specific call, and revert show_full_output back to unset/false

Generated by Claude Code

permission_denials_count dropped from 17 to 1 after the allowed-tools
fix, but the review still isn't posted (still zero comments/reviews on
same-repo PRs). The action hides Claude's tool-call stream by default,
so there's no way to see which specific call the remaining denial is
from the log alone. Enable verbose output to capture it, then revert
this once diagnosed.
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1-2-g6ad689f
Preview removed because the pull request was closed.
2026-08-01 05:17 UTC

@d-morrison
d-morrison merged commit c220607 into main Aug 1, 2026
5 checks passed
@d-morrison
d-morrison deleted the claude/claude-review-debug-output branch August 1, 2026 05:16
d-morrison pushed a commit to imelainew/ucd-serg.github.io that referenced this pull request Aug 1, 2026
The previous claude_args only allowlisted the final posting step
(gh pr comment + the inline-comment MCP tool), on the assumption those
were the only calls that mattered. The verbose log from UCD-SERG#93 (commit
644d3f4, job 91330470808) showed otherwise: claude_args replaces the
effective tool allowlist rather than adding to it, so the narrower list
also denied gh pr diff, gh pr view, and other calls the plugin's own
steps make to gather context before it ever reaches the posting step -
it never even attempted gh pr comment or the inline tool. Replace the
list with the code-review plugin's own declared allowed-tools
(plugins/code-review/commands/code-review.md's frontmatter in
anthropics/claude-code) so its own steps aren't blocked.
d-morrison added a commit to imelainew/ucd-serg.github.io that referenced this pull request Aug 1, 2026
The code-review plugin gates all posting on a --comment argument:
"If --comment argument was NOT provided, stop here. Do not post any
GitHub comments." (step 7 of plugins/code-review/commands/code-review.md
in anthropics/claude-code.)

We have never passed it, so every review this repo has run has been
working as designed -- reviewing, printing to the job log, and posting
nothing behind a green check. claude has zero review comments across
UCD-SERG#78, UCD-SERG#79, UCD-SERG#80, UCD-SERG#86, UCD-SERG#87, UCD-SERG#92, UCD-SERG#93 and UCD-SERG#94.

This was not a permissions problem. UCD-SERG#91's pull-requests: write and
UCD-SERG#92/UCD-SERG#94's allowlist work were treating a symptom.

Closes UCD-SERG#96

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HMmB6db4xpbuqcqaQKArZb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants