Skip to content

Fix Wavedrom in Jupyter Notebook #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryoon wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix Wavedrom in Jupyter Notebook #484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b28b05
Fix Wavedrom in Jupyter Notebook
ryoon Jun 5, 2026
2a89bb0
Remove unused `Javascript` from import
ryoon Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions pyrtl/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1763,7 +1763,6 @@ def render_trace(
if _currently_in_jupyter_notebook():
from IPython.display import (
HTML,
Javascript,
display,
)

Expand All @@ -1775,16 +1774,12 @@ def render_trace(
html_elem = HTML(htmlstring)
display(html_elem)
# print(htmlstring)
js_stuff = """
$.when(
$.getScript("https://cdnjs.cloudflare.com/ajax/libs/wavedrom/1.6.2/skins/default.js"),
$.getScript("https://cdnjs.cloudflare.com/ajax/libs/wavedrom/1.6.2/wavedrom.min.js"),
$.Deferred(function( deferred ){
$( deferred.resolve );
})).done(function(){
WaveDrom.ProcessAll();
});"""
display(Javascript(js_stuff))
html_stuff = """
<script src="https://cdnjs.cloudflare.com/ajax/libs/wavedrom/1.6.2/skins/default.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/wavedrom/1.6.2/wavedrom.min.js"></script>
<style onload="WaveDrom.ProcessAll();"></style>
"""
display(HTML(html_stuff))
else:
self.render_trace_to_text(
trace_list=trace_list,
Expand Down
Loading