fix(framework): ensure animation mode work - #13941
Open
nnaydenow wants to merge 4 commits into
Open
Conversation
|
🚀 Deployed on https://pr-13941--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
--_ui5-animation-modeCSS variable on configuration —AnimationMode.tsnow callscreateOrUpdateStyle(via
document.adoptedStyleSheets) to keep--_ui5-animation-modein sync with the configured animation mode, bothon initial read and on every
setAnimationModecall. Uses adopted stylesheets so the variable is not visible as aninline style in DevTools.
Add
CommonStyles.csswith animation suppression — a new@container style(--_ui5-animation-mode: none)blocksets
transition-durationandanimation-durationto0son every element inside a component's shadow root whenanimation mode is
none, ensuring animations complete instantly while preserving their end state.Apply
CommonStyleseagerly —getComponentStyles()now populates the stylesheet immediately from thepre-loaded
packageMapinstead of waiting forapplyThemeto callupdateComponentStyles, so the animationsuppression rule is active from the very first render.
Convert
durationto a function —animate.tsexportsdurationas() => numberinstead of a staticconstant, so it reflects the current animation mode at call time. Updated all consumers (
scroll.ts,slideDown.ts,slideUp.ts).Test plan
ConfigurationChange.cy.tsx— verify--_ui5-animation-modeis set on:rootand updates correctly viasetAnimationModeConfigurationScript.cy.tsx— verify CSS variable matches the value from the config scriptConfigurationURL.cy.tsx— verify CSS variable matches the value from URL params and that script config takesprecedence over URL
AnimationMode.cy.tsx— verifyduration()returns0when mode isnoneand400otherwise; verifyCommonStylessheet is adopted into shadow roots and contains the--_ui5-animation-moderule