✨ feat: 포커스 도서 선택 화면 UI 퍼블리싱 #337 - #361
Merged
Merged
Conversation
# Conflicts: # src/types/focus/focus.ts
✅ Deploy Preview for readingnook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seoyeon0103
approved these changes
Aug 31, 2026
seoyeon0103
left a comment
Collaborator
There was a problem hiding this comment.
완전 수고많으셨습니다. 머지 할게요~!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 관련 이슈
🔑 작업 내용
도서 선택 화면
/focus/select도서 선택 UI 구현/focus/theme이동FocusLibraryBookItem타입 및 mock 데이터 추가검색 및 최근 검색어
idle·searching·results상태 분리<→X전환✅ 공용 컴포넌트 변경 ✅
SearchField필요 이유
변경 내용
showClearOnFocus,onClear,maxLength옵션 추가onClear실행 후 input blur 처리text-body-16-r토큰으로 치환caret-gray-50토큰으로 치환size-*문법으로 정리변경 결과
RecentKeywordSection필요 이유
변경 내용
maxTextLength옵션 추가showAllKeywords옵션 추가변경 결과
Chip의 다른 사용처에는 focus 동작 변경 없음Chip6pxpadding을 동일한py-1.5로 치환8pxradius를 동일한rounded-lg로 치환Chip전체에 적용됐던 mouse down 처리를 제거하고 최근 검색어 영역으로 범위 한정none·iconvariant의 기존 크기·타이포·색상 유지📷 스크린샷
🌐 공유 사항 to 리뷰어
중점 확인 요청
SearchFieldoptional prop 추가 후 기존 검색 화면 동작 유지 여부검증
npm run build통과git diff --check통과SearchField타이포·caret·아이콘 computed style 동일 확인Chipvariant 크기·타이포·padding·radius 동일 확인/focus/theme이동 확인🚨 이슈 사항
npm run lint: 기존 파일 오류 25건으로 실패