feat(oauth): persist client authentication method - #1523
Closed
NicolaiSchmid wants to merge 1 commit into
Closed
Conversation
Author
|
i'm sorry for this pr! my agent filed it without checking back with me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
client_secret_basicconsistently to authorization-code exchange, refresh, and client-credentials requestsclient_secret_postas the default for existing and unspecified clientsWhy
Some OAuth providers require
client_secret_basicand reject credentials sent in the request body. Executor's low-level OAuth helpers already supported Basic authentication, but the client model did not persist that choice, so refreshes and service-managed exchanges reverted to the body default.Validation
bun run format:checkbun run lintbun run typecheckcodex review --uncommitted: no actionable correctness issuesThe repository-wide test command otherwise reached an unrelated host-environment failure in the MCP Apps browser suite because
/usr/bin/google-chromeis unavailable; all SDK tests passed.