Skip to content

chore(oneidentity): include central account in missing person error #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janosbabik wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore(oneidentity): include central account in missing person error #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/queue/consumers/oneidentity/consumerCallbacks/syncVisitToOneIdentityHandler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,9 @@ describe('syncVisitToOneIdentityHandler', () => {

await expect(
syncVisitToOneIdentityHandler(visitMessage, Event.VISIT_DELETED)
).rejects.toThrow('Person not found in One Identity');
).rejects.toThrow(
'Person with central account "visitor-oidc-sub" not found in One Identity'
);

expect(mockOneIdentity.login).toHaveBeenCalled();
expect(mockOneIdentity.getPerson).toHaveBeenCalledWith(
Expand Down Expand Up @@ -998,7 +1000,9 @@ describe('syncVisitToOneIdentityHandler', () => {

await expect(
syncVisitToOneIdentityHandler(visitMessage, Event.VISIT_UPDATED)
).rejects.toThrow('Person not found in One Identity');
).rejects.toThrow(
'Person with central account "visitor-oidc-sub" not found in One Identity'
);

expect(mockOneIdentity.login).toHaveBeenCalled();
expect(mockOneIdentity.getPerson).toHaveBeenCalledWith(
Expand Down
4 changes: 3 additions & 1 deletion src/queue/consumers/oneidentity/consumerCallbacks/syncVisitToOneIdentityHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ async function getScienceUser(
const person = await oneIdentity.getPerson(centralAccount);

if (!person) {
throw new Error('Person not found in One Identity');
throw new Error(
`Person with central account "${centralAccount}" not found in One Identity`
);
}

if (person.CCC_EmployeeSubType === IdentityType.ESSSCIENCEUSER)
Expand Down
Loading