fix: fix bug with pdf downloads for tokens with draft propsals - #1721
Open
TCMeldrum wants to merge 1 commit into
Open
fix: fix bug with pdf downloads for tokens with draft propsals#1721TCMeldrum wants to merge 1 commit into
TCMeldrum wants to merge 1 commit into
Conversation
TCMeldrum
marked this pull request as ready for review
August 13, 2026 15:10
TCMeldrum
changed the title
j4mes-4rgent
approved these changes
Aug 13, 2026
ACLay
approved these changes
Aug 14, 2026
simonfernandes
approved these changes
Aug 17, 2026
yoganandaness
requested changes
Aug 26, 2026
| ...answer, | ||
| value, | ||
| }); | ||
| if (answer.answerId !== null) { |
Contributor
There was a problem hiding this comment.
Should we also handle the type as well?
As per the type definition, answerId is non nullable. In the case, I would recommend to refine the type definition as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug that was preventing the download of PDFs for tokens with draft properties.
Motivation and Context
The change is required to allow users to download PDFs proposals that have a insturment picker question but have not answered that question, which was previously not possible due to a bug.
Changes
answerIdis not null before attempting to fetch the call byanswerIdproposal.How Has This Been Tested?
Fixes Jira Issue
https://jira.ess.eu//browse/
Depends On
Tests included/Docs Updated?