fix: enforce question-level permissions for questionary reads and updates - #1735
Open
janosbabik wants to merge 5 commits into
Open
fix: enforce question-level permissions for questionary reads and updates#1735janosbabik wants to merge 5 commits into
janosbabik wants to merge 5 commits into
Conversation
janosbabik
commented
Aug 21, 2026
janosbabik
commented
Contributor
- Filter blank questionnaire steps according to the current user’s read permissions.
- Prevent users from submitting answers to questions they are not permitted to access.
- Ensure cleanup only affects omitted answers from questions the user can read.
janosbabik
requested review from
TCMeldrum,
ellen-wright and
jekabs-karklins
and removed request for
a team and
ellen-wright
August 21, 2026 13:35
janosbabik
changed the title
| (answer) => answer.question.id === submittedAnswer.questionId | ||
| ); | ||
|
|
||
| return currentAnswer != null && !hasQuestionReadPermission(currentAnswer); |
Contributor
There was a problem hiding this comment.
issue: we should change && to ||. I have attached the issue as md file.
Additionally what claude found it is much easier to get all the question ids even without guessing because blankQuestionary is not Authed at all and returns all questions with their IDs
Contributor
Author
There was a problem hiding this comment.
You are right, this needs to be changed. I will update it. Thx!
jekabs-karklins
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.