fix: review_data view remove duplicates - #1736
Open
zacharyjhankin wants to merge 4 commits into
Open
Conversation
zacharyjhankin
requested review from
ellen-wright
and removed request for
a team
August 21, 2026 13:47
jkramya
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was previously a bug in the view that shows review_data because there was a join that did not filter properly.
LEFT JOIN fap_meeting_decisions fmd ON fmd.proposal_pk = p.proposal_pk
became:
LEFT JOIN fap_meeting_decisions fmd ON fmd.proposal_pk = p.proposal_pk
AND fmd.instrument_id = i.instrument_id
As fap_meeting_decisions has an instrument_id column that was not being taken into account meaning multiple fap_meeting_decisions for different instruments would all be joined, effectively duplicating the rows we want for the entire view. As each row should represent one instrument.
You can test this by pressing the 'Export Fap Data' button in the calls screen. When you have proposals that have multiple fap reviews for different instruments on the same proposal. Then you get duplicates without my change. Or just execute the SQL to see what appears.
Motivation and Context
How Has This Been Tested
Fixes
Changes
Depends on
Tests included/Docs Updated?