feat: include visit registration questionary answers in visit messages - #1740
Open
janosbabik wants to merge 1 commit into
Open
feat: include visit registration questionary answers in visit messages#1740janosbabik wants to merge 1 commit into
janosbabik wants to merge 1 commit into
Conversation
janosbabik
requested review from
Jonathan-Swales and
jekabs-karklins
and removed request for
a team and
Jonathan-Swales
August 24, 2026 10:03
jekabs-karklins
left a comment
Contributor
There was a problem hiding this comment.
Looks good - I left a commend on messagebroker WDYT.
Comment on lines
+354
to
+361
| registrationAnswers.push( | ||
| ...questionarySteps.flatMap((step) => | ||
| step.fields.map((field) => ({ | ||
| questionNaturalKey: field.question.naturalKey, | ||
| value: field.value, | ||
| })) | ||
| ) | ||
| ); |
Contributor
There was a problem hiding this comment.
Suggested change
| registrationAnswers.push( | |
| ...questionarySteps.flatMap((step) => | |
| step.fields.map((field) => ({ | |
| questionNaturalKey: field.question.naturalKey, | |
| value: field.value, | |
| })) | |
| ) | |
| ); | |
| registrationAnswers.push( | |
| ...questionarySteps.flatMap((step) => | |
| step.fields | |
| .filter((field) => | |
| areDependenciesSatisfied(questionarySteps, field.question.id) | |
| ) | |
| .map((field) => ({ | |
| questionNaturalKey: field.question.naturalKey, | |
| value: field.value, | |
| })) | |
| ) | |
| ); |
Can we add this check already, to make sure in case we introduce questions with dependencies the unanswered questions get filtered out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds visit registration questionary answers to visit message payloads using question natural keys.
New payload format: