Fix bug in 2 concurrent user editing proposal - #1749
Open
zacharyjhankin wants to merge 1 commit into
Open
Conversation
zacharyjhankin
requested review from
SourangshuSTFC and
TCMeldrum
and removed request for
a team
August 26, 2026 08:51
yoganandaness
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in this code where if you edit a instrument picker question when someone else edits it then the answerId gets miss-matched with the backend causing problems on render.
Specifically if you have personA and personB editing the same proposal where the answerId of a question is for example 100. When personA presses save, the backend deletes the entry with 100 in it, and saves a new answer with 101 as the answerId. Then when personB presses save they get a popup showing both answers but the renderer is passed two Ids, 101 and 100 for the new answer and old answer. as 100 no longer exists we get an error saying that it could't find the call from answer id 100. Because 100 no longer exists.