fix: await promises in VisitAuthorization hasReadRights

[jekabs-karklins]

The two async checks in VisitAuthorization.hasReadRights were never awaited which caused issue that visitor could not load the questionaire.

return (
  visit.creatorId === agent.id ||                                  // sync
  this.proposalAuth.isMemberOfProposal(agent, visit.proposalPk) || // async, not awaited
  this.visitDataSource.isVisitorOfVisit(agent.id, visit.id)        // async, not awaited
);

The first line is sync, and the last two is async.

one is false → || moves on
two is a pending Promise → truthy → || short-circuits and returns two itself
three is never evaluated

The method was silently equivalent to:

return visit.creatorId === agent.id || (await this.proposalAuth.isMemberOfProposal(...));

The visitor-list check was dead code for everyone. Proposal members passed on the second check, so this only surfaced for a user on the visitor list who is not a proposal member — they saw Failed to load questionary details when opening the visit registration.

How Has This Been Tested

Manually, as the reporting visitor: the visit registration questionary now loads.

Fixes

SWAP-5726

Changes

apps/backend/src/auth/VisitAuthorization.ts — await both async checks.

[yoganandaness]

Can we add some parallelization?

const [isMember, isVisitor] = await Promise.all([
this.proposalAuth.isMemberOfProposal(agent, visit.proposalPk),
this.visitDataSource.isVisitorOfVisit(agent.id, visit.id),
]);

return visit.creatorId === agent.id || isMember || isVisitor;