Dev playlists links - #224
Open
lipsa-b wants to merge 132 commits into
Open
Conversation
# Conflicts: # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/launcher/AppLauncherViewModel.kt
# Conflicts: # respect-app-compose/src/commonMain/kotlin/world/respect/app/app/App.kt
… to include Home navigation and verify Playlists visibility
… to include Home navigation and verify Playlists visibility
…w to match UI text change for playlist creation.
mikedawson
reviewed
Aug 13, 2026
| } | ||
|
|
||
| @Composable | ||
| private fun FeedActionButton( |
Member
There was a problem hiding this comment.
@lipsa-b we already have RespectQuickActionButton which is used for this purpose on all other screens. This clearly goes against the Don't Repeat Yourself principle at the top of the important section of the coding guidelines. Please do not add something new without first checking if there is something suitable already in the code.
…of RespectQuickActionButton (went against DRY principle).
mikedawson
reviewed
Aug 13, 2026
| } | ||
|
|
||
| fun onClickShare() { | ||
| val feedUrl = _uiState.value.feed?.selfUrl() |
Member
There was a problem hiding this comment.
@lipsa-b : I don't see why use this instead of just using the route.opdsFeedUrl - this seems to be making it more complicated than needed.
Refactor LearningUnitSelection to allow for multi selection. Avoid crash on assigning long lists. Handle getting xapi activity info for selecting learning units.
…display of header icon and description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.