Card Definitions

GreenTag

Good things such as:

e.g.

• Code that follows patterns and can be re-used for future tasks
• Designs that elegantly reduce the number of clicks/taps/steps

YellowTag

Non-critical problems that should be minimized

e.g.

• Deviations in use of naming patterns: (e.g. PersonDetailViewModel and PeopleListViewModel instead of PersonListViewModel)
• Inefficient code: e.g. not using remember functions appropriately in Jetpack compose
• Designs that deviate slightly from Material design (e.g. dialog with wrong button style)

RedTag

Major problem: the task is not ready for the next phase, and that should have been known.

e.g.

• Copy/pasting the same code in multiple places (going against very important section of coding guidelines) instead of using a domain UseCase, extension function, or other suitable code re-use mechanism: makes the code far more difficult to maintain, more likely to have bugs, harder to fix bugs etc.
• Ignoring important feedback comments (challenging feedback is always OK; feedback can be mistaken).
• Designs that miss use cases described in the task card, are clearly ambiguous, etc.