Remove amplitude columns and use LoadAllSpikes() with trigger-aligned timestamps - #20
Merged
Conversation
This removes waveform loading, electrode-grid loops, and amplitude calculations. LoadAllSpikes() provides trigger-aligned timestamps instead of waveform start start time. Maps unique hardware channels through ChannelArray. The export is no longer sorted, but preserves LoadAllSpikes() order. (order does not matter for creating the raster plots).
There was a problem hiding this comment.
Pull request overview
Updates MATLAB spike extraction to use trigger-aligned timestamps and simplifies CSV output.
Changes:
- Uses
LoadAllSpikes()and maps hardware channels throughChannelArray. - Removes waveform amplitude columns.
- Naturally sorts well labels in the raster plot UI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
rasterplot.py |
Sorts well labels by row and numeric column. |
extract_spk_with_axisfile_matlab.m |
Exports trigger-aligned spike timestamps and channel mappings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes waveform loading, electrode-grid loops, and amplitude calculations.
LoadAllSpikes()provides trigger-aligned timestamps instead of waveform start start time. Maps unique hardware channels throughChannelArray. The export is no longer sorted, but preservesLoadAllSpikes()order. (order does not matter for creating the raster plots).Fixes #16.