Match trigger-aligned timestamp extraction in Octave - #30
Merged
Conversation
- Omit amplitude columns in CSV export - Use trigger-aligned spike timings via LoadAllSpikes() and ChannelArray - Include file loading checks from matlab version
There was a problem hiding this comment.
Pull request overview
Aligns Octave spike extraction with MATLAB’s trigger-aligned workflow.
Changes:
- Uses
LoadAllSpikes()and maps hardware channels. - Exports three CSV columns with MATLAB-matching precision.
- Updates Octave loader compatibility checks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
process_spk.py |
Validates the updated Octave loader requirements. |
extract_spk_with_axisfile_octave.m |
Implements trigger-aligned extraction and streamlined CSV output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%.15g) as MATLAB writetable.Fixes #28.