docs(roadmap): note i18n tooling gaps found during debt repayment - #117
Merged
Conversation
…REPAYMENT Not part of that lot (translation content only) - candidates for a future tooling lot: - translate_i18n.py requires a separate ANTHROPIC_API_KEY; a Claude Code headless-mode path would work off the existing subscription instead, at the cost of CI-compatibility and a different cost model. - i18n_dict_utils.py's parser doesn't distinguish a live dictionary entry from one commented out with "-- STALE: ", so translate_i18n.py and check_i18n_diff.py both treat dead keys as real stubs/diffs.
Reviewer's GuideDocumentation-only PR updating dev/roadmap.md to capture two i18n tooling gaps discovered during previous debt repayment work, outlining current behavior and proposed directions for future improvements. Sequence diagram for translate_i18n.py Anthropic API vs Claude Code CLI flowsequenceDiagram
participant translate_i18n_py
participant anthropic_sdk
participant claude_cli
translate_i18n_py->>anthropic_sdk: use ANTHROPIC_API_KEY
anthropic_sdk-->>translate_i18n_py: return translations
alt future_claude_code_path
translate_i18n_py->>claude_cli: call claude -p prompt
claude_cli-->>translate_i18n_py: return translations
end
Flow diagram for i18n_dict_utils.py parse_dict handling STALE entriesflowchart LR
A[parse_dict line] --> B[strip line]
B --> C{starts with --}
C -->|yes| D[ignore entry]
C -->|no| E[match _ENTRY_RE]
E --> F[emit dictionary entry]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="dev/roadmap.md" line_range="124-125" />
<code_context>
+une clé API séparée — le script pourrait shell-out vers ce mode au lieu d'utiliser le SDK
+`anthropic`. Compromis à trancher : ça suppose une session Claude Code authentifiée disponible
+partout où le script tourne, ce qui exclut la CI (contrairement à la clé API, qui elle s'y prête) ;
+et ça change le modèle de coût (quota d'abonnement au lieu de facturation API). À grill avant de
+lancer un lot : faut-il un mode dual (API si dispo, sinon CLI), ou remplacer complètement ?
+
+## TOOLING — `i18n_dict_utils.py` ne distingue pas une entrée `-- STALE:` d'une entrée live
</code_context>
<issue_to_address>
**issue (typo):** Typo in “À grill avant de” — “grill” should be corrected.
“À grill avant de lancer un lot” contient vraisemblablement une faute : “grill” n’est pas correct en français ici. Remplace-le par le verbe ou l’expression voulue (par ex. une forme de “griller / mettre sur le grill” ou un autre verbe approprié).
```suggestion
et ça change le modèle de coût (quota d'abonnement au lieu de facturation API). À clarifier avant de
lancer un lot : faut-il un mode dual (API si dispo, sinon CLI), ou remplacer complètement ?
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+124
to
+125
| et ça change le modèle de coût (quota d'abonnement au lieu de facturation API). À grill avant de | ||
| lancer un lot : faut-il un mode dual (API si dispo, sinon CLI), ou remplacer complètement ? |
There was a problem hiding this comment.
issue (typo): Typo in “À grill avant de” — “grill” should be corrected.
“À grill avant de lancer un lot” contient vraisemblablement une faute : “grill” n’est pas correct en français ici. Remplace-le par le verbe ou l’expression voulue (par ex. une forme de “griller / mettre sur le grill” ou un autre verbe approprié).
Suggested change
| et ça change le modèle de coût (quota d'abonnement au lieu de facturation API). À grill avant de | |
| lancer un lot : faut-il un mode dual (API si dispo, sinon CLI), ou remplacer complètement ? | |
| et ça change le modèle de coût (quota d'abonnement au lieu de facturation API). À clarifier avant de | |
| lancer un lot : faut-il un mode dual (API si dispo, sinon CLI), ou remplacer complètement ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
translate_i18n.pyrequires a separateANTHROPIC_API_KEY(own billing) - a Claude Code headless-mode path (claude -p) could use the existing subscription instead, trading CI-compatibility for that.tools/build/i18n_dict_utils.py's parser doesn't distinguish a live dictionary entry from one commented out with-- STALE:, sotranslate_i18n.pyandcheck_i18n_diff.pyboth treat dead keys as real stubs/diffs. Also noted: KO/ES dictionaries carry empty entries thatCTLD_i18n_en.luaalready marks-- STALE:but that aren't marked stale in KO/ES themselves - possible sync drift ingenerate_i18n_dicts.ps1, not yet root-caused.dev/roadmap.mdonly.Test plan
Generated with Claude Code
Summary by Sourcery
Document i18n tooling limitations and follow-up work in the roadmap related to translation workflow and stale dictionary handling.
Documentation:
-- STALE:entries and investigate sync drift between language dictionaries.